Associate GlobalIDFilter with BigAutoField and SmallAutoField#1496
Open
iamthad wants to merge 2 commits intographql-python:mainfrom
Open
Associate GlobalIDFilter with BigAutoField and SmallAutoField#1496iamthad wants to merge 2 commits intographql-python:mainfrom
iamthad wants to merge 2 commits intographql-python:mainfrom
Conversation
This was introduced in Django 3.0 and the project requires Django >= 3.2
Contributor
|
I originally added the |
sjdemartini
approved these changes
Feb 1, 2024
Collaborator
sjdemartini
left a comment
sjdemartini
left a comment
There was a problem hiding this comment.
Cool, thanks for updating this!
Author
|
I realized today, that in the spirit of https://xkcd.com/1172/, this will be a breaking change for those who were relying on the old behavior. Their APIs will start requiring global IDs on ID filters instead of integers. How should this be addressed? Maybe a note in the changelog about how to restore the old behavior would be sufficient? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AutoFieldis set up to useGlobalIDFilter, butBigAutoFieldandSmallAutoFieldare not.This PR adds them to
GRAPHENE_FILTER_SET_OVERRIDES, associating them with the filter.It also removes some conditional logic around
SmallAutoFieldthat was introduced in #1212 becauseSmallAutoFieldwas introduced in Django 3.0 and this project now requires a minimum Django version of 3.2.